Skip to content

[Excel] (custom functions) unified manifest support for xll preference #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Jun 11, 2025

Cannot merge until the xllCustomFunctions property in the unified manifest is moved to its proper place as a child of the "prefer" property.
UPDATE: This has now happened.

@Rick-Kirkham Rick-Kirkham added the Status: Do Not Merge Do Not Merge label Jun 11, 2025
Copy link
Contributor

Learn Build status updates of commit ef13bf3:

💡 Validation status: suggestions

File Status Preview URL Details
docs/excel/make-custom-functions-compatible-with-xll-udf.md 💡Suggestion View Details

docs/excel/make-custom-functions-compatible-with-xll-udf.md

  • Line 27, Column 376: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-365/extensibility/schema/extension-alternate-versions-array-prefer-xll-custom-functions#filename' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@Rick-Kirkham Rick-Kirkham requested a review from alison-mk June 11, 2025 21:07
@Rick-Kirkham Rick-Kirkham removed the Status: Do Not Merge Do Not Merge label Jun 12, 2025
Copy link
Contributor

@alison-mk alison-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I can't confirm that the xllCustomFunctions property has been moved. It looks to me like it's still a child of alternates and not a child of prefer: https://learn.microsoft.com/en-us/microsoft-365/extensibility/schema/extension-xll-custom-functions?view=m365-app-prev&tabs=syntax

Cannot merge until the xllCustomFunctions property in the unified manifest is moved to its proper place as a child of the "prefer" property.
UPDATE: This has now happened.

@Rick-Kirkham
Copy link
Contributor Author

Approving, but I can't confirm that the xllCustomFunctions property has been moved. It looks to me like it's still a child of alternates and not a child of prefer: https://learn.microsoft.com/en-us/microsoft-365/extensibility/schema/extension-xll-custom-functions?view=m365-app-prev&tabs=syntax

Cannot merge until the xllCustomFunctions property in the unified manifest is moved to its proper place as a child of the "prefer" property.
UPDATE: This has now happened.

The fix isn't in the reference documentation, because it was just made last week and the reference hasn't been autogenerated since then. But the fix is in the actual schema: DevPreview/MicrosoftTeams.schema.json

@Rick-Kirkham Rick-Kirkham merged commit 8e69aa0 into main Jun 19, 2025
2 checks passed
@Rick-Kirkham Rick-Kirkham deleted the xll-prefer branch June 19, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants